![]() Github-review-comment and github-review-reject. Once your are done, you can submit your review with one of github-review-approve, # lines and will be submitted as a top level review comment # This is a global comment at the top of the file ~ I also opened an issue on the cheat sheet repo to follow up with the author of You can add comments inline by adding lines starting with # inline. You can add comments at the top level by writing lines starting with # after the PR description and before the beginning of the diff. ![]() +++ -18,7 +18,7 rich-text editing, and UI widgets/controls. a/content/reference/google-closure-library.adoc ĭiff -git a/content/reference/google-closure-library.adoc b/content/reference/google-closure-library.adoc ~ I also opened an issue on the cheat sheet repo to follow up with the author of the cheat sheet. This commit replaces the now defunkt link to $ ~ The owner of lost the domain and does not intend to maintain it. The diff contains the description of the PR at the top with line You will, then be prompted with a buffer containing the diff of the In emacs you can start by calling github-review-start and entering a Pull I built github-review an Emacs package to format and submit GitHub code reviews! Integration for GitHub pull requests and I wanted to build the same kind of Wouldn’t it be nice to be able to review code in your favorite editor? I have to quit my editor, open a browser (be online at the time), and click a lot!.To write code blocks and I often end up missing some indentation or syntax I like to provide code snippets in comments, with the web UI it is not as easy.I often check surrounding code to understand how it all fits together, which isn’t easy to do with a Web UI as opposed to a.So I'd rather have it switch space and use the existing frame, even for lazy loading.At work, my team uses GitHub enterprise to store and manage our repositories. However, that's only appropriate for lazy loading a desktop and would otherwise not be what you'd expect. The only thing I would add is that if you solely use Aquamacs it is better to edit the file Preference. The post from Sean Allred helped me find the answer I was looking for. ![]() What is the behavior you would find more appropriate? Switching to a workspace that has the selected frame, and using that?įor the situation I described, it would be even better if it didn't switch spaces, but just opened the buffer in the existing frame regardless. I am using Aquamacs and had the same question. It's actually trying to open a new frame in the space I'm in, but since I've got it pinned to space it first switches to that space, resulting in a new frame on top of the original one. I wondered why that was, but the issue described here makes sense of it. Aquamacs will then bring me back to the original space and open a new frame on top of the old one. When I start Aquamacs and it starts loading buffers (lazy loading), I might switch to another space to check e-mail for instance. I've got Aquamacs pinned to one (of four) spaces and I'm using the desktop save/restore feature. This however most probably has to do with all frame creations and is a separate issue.
0 Comments
Leave a Reply. |